Add IP version to IP Pool database objects #8885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnaecker
force-pushed
the
add-ip-family-to-pools
branch
3 times, most recently
from
96477a9 to
7dad31f
Compare
|
This is an interesting failure mode. Seems like OPTE failed in a call to |
- Add an `IpVersion` type and attach to all IP Pool objects - Schema and data migration to add the version to IP Pools in the database - Add a services IP Pool for IPv6 addresses - Ensure we can only add ranges to pools of the same version - Fixes a bunch of knock-on effects of splitting out the pools by IP version - Closes #8880
bnaecker
force-pushed
the
add-ip-family-to-pools
branch
from
7dad31f to
3d4a484
Compare
That's an unpleasant one to hit! I've opened oxidecomputer/opte#840. |
bnaecker
requested review from
david-crespo,
internet-diglett and
rcgoodfellow
nexus/db-queries/src/db/datastore/deployment/external_networking.rs
Outdated
Show resolved
Hide resolved
david-crespo
approved these changes
Aug 25, 2025
There was a problem hiding this comment.
Looks great. I don't see any real issues. The only thing I would really recommend is making the sure the DB pool matches the authz pool in #8885 (comment).
- Helper IP Pool constructors - Local SQL settings - Simplify caching IP Pools when ensuring an external address - Add sanity check that DB / Authz pool IDs match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IpVersiontype and attach to all IP Pool objects